Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Implement missing import state functions #57

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Sep 11, 2024

Implemented ImportState function for plural_pr_automation_trigger and plural_stack_run_trigger resources. plural_pr_automation_trigger will use pr_automation_id,pr_automation_branch as import identifier and plural_stack_run_trigger will use id (stack ID).

Resources mentioned above are write-only (Read function is empty) just like plural_rbac however we can implement import to avoid errors like the one from the ticket. Import requires providing all required fields from config as we cannot read them from anywhere.

Related docs.

@maciaszczykm maciaszczykm added the enhancement New feature or request label Sep 11, 2024
Copy link

linear bot commented Sep 11, 2024

@maciaszczykm maciaszczykm merged commit fc28347 into main Sep 12, 2024
11 checks passed
@maciaszczykm maciaszczykm deleted the marcin/prod-2622-pr-automation-trigger-resource-import-not-implemented branch September 12, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants